No funded issue found.
Check out the Issue Explorer
Be the OSS Funding you wish to see in the world.
Looking to fund some work? You can submit a new Funded Issue here .
Time left
Opened
Issue Type
Workers Auto Approve
Project Type
Time Commitment
Experience Level
Permissions
Accepted
Reserved For
eth_signtransaction RPC method not implemented
aionnetwork
Java, C, C++, CSS, Shell, Makefile, Python, CMake, Roff, Visual Basic, HTML, Dockerfile, Batchfile
Updated by @qoire and @kzeine :
# Introduction
The Web3 1.0 has a method named `eth.signTransaction`, that calls an RPC method named `eth_signTransaction`. `eth_signTransaction` is not implemented in the kernel. The purpose of it is to ask the kernel to sign a given transaction, but not send it (unlike `eth_sendTransaction`), so that the client can have the signed transaction to send at a later time (via `eth_sendRawTranaction`).
# Current situation
This feature is missing in the current Aion implementation. The following error occurs:
Web3 1.0 JS invocation:
```
aion-127.0.0.1:8545> eth.signTransaction({ from:'0xa0450c4333e72ed26552d7462c0b3669924eec816a219b3960d5b3f0b33f7444', to:'0xa0b88269779d225510ca880ed742e445db0c70efb1ee3159b6d56479ae3501f9', gasPrice:10000000, gas:12345, value:"1337", data:""} ).then(console.log);
Promise {
,
domain:
Domain {
domain: null,
_events:
{ removeListener: [Function: updateExceptionCapture],
newListener: [Function: updateExceptionCapture],
error: [Function: debugDomainError] },
_eventsCount: 3,
_maxListeners: undefined,
members: [] } }
aion-127.0.0.1:8545> (node:13250) UnhandledPromiseRejectionWarning: Error: Returned error: Method not found
at Object.ErrorResponse (/home/sergiu/repos/aion_web3/packages/web3-core-helpers/src/errors.js:29:16)
at /home/sergiu/repos/aion_web3/packages/web3-core-requestmanager/src/index.js:140:36
at XMLHttpRequest.request.onreadystatechange (/home/sergiu/repos/aion_web3/packages/web3-providers-http/src/index.js:91:13)
at XMLHttpRequestEventTarget.dispatchEvent (/home/sergiu/repos/aion_web3/packages/web3-providers-http/node_modules/xhr2-cookies/dist/xml-http-request-event-target.js:34:22)
at XMLHttpRequest._setReadyState (/home/sergiu/repos/aion_web3/packages/web3-providers-http/node_modules/xhr2-cookies/dist/xml-http-request.js:208:14)
at XMLHttpRequest._onHttpResponseEnd (/home/sergiu/repos/aion_web3/packages/web3-providers-http/node_modules/xhr2-cookies/dist/xml-http-request.js:318:14)
at IncomingMessage. (/home/sergiu/repos/aion_web3/packages/web3-providers-http/node_modules/xhr2-cookies/dist/xml-http-request.js:289:61)
at IncomingMessage.emit (events.js:187:15)
at IncomingMessage.EventEmitter.emit (domain.js:460:23)
at endReadableNT (_stream_readable.js:1085:12)
```
Log from kernel:
```
18-09-12 12:18:35.237 DEBUG API [XNIO-1 task-83]: rpc-server - invalid method: eth_signTransaction [1]
```
# Task Description
We're asking for contributors to implement this feature for https://github.com/aionnetwork/aion.
Correct implementation should receive a transaction, sign it, and return the signed transaction as described here: https://web3js.readthedocs.io/en/1.0/web3-eth.html#signtransaction.
# Acceptance Criteria
- The code implements the targets described above
- The code is well documented and fully covered by unit tests
- The code is compliant with Aion's code convention
- The code gets merged into the main code repository
# Required Skill
Participants needs to have experience in Java software development, and have basic knowledge about blockchain system. Participants might need to read Ethereum's documentation to understand the task.
# Guidance
Technical support is available through [Gitter](https://gitter.im/aionnetwork/Lobby).
---
Original post:
_Before filing a new issue, please **provide the following information**._
> I'm running:
>
> - **Which Aion version?**: 0.3.1.8dc6870
> - **Which operating system?**: Linux
> - **Which distributor and version?**: Ubuntu 16.04
> - **How installed?**: source
> - **Are you fully synchronized?**: yes
> - **Did you try to restart the node?**: yes
_Your issue description goes here below. Try to include **actual** vs. **expected behavior** and **steps to reproduce** the issue._
The Web3 1.0 has a method named `eth.signTransaction`, that calls an RPC method named `eth_signTransaction`. `eth_signTransaction` is not implemented in the kernel. The purpose of it is to ask the kernel to sign a given transaction, but not send it (unlike `eth_sendTransaction`), so that the client can have the signed transaction to send at a later time (via `eth_sendRawTranaction`).
Since there's still other ways to send transaction or sign transactions, this isn't very high priority, just making an issue to keep track of it
Web3 1.0 JS invocation:
```
aion-127.0.0.1:8545> eth.signTransaction({ from:'0xa0450c4333e72ed26552d7462c0b3669924eec816a219b3960d5b3f0b33f7444', to:'0xa0b88269779d225510ca880ed742e445db0c70efb1ee3159b6d56479ae3501f9', gasPrice:10000000, gas:12345, value:"1337", data:""} ).then(console.log);
Promise {
,
domain:
Domain {
domain: null,
_events:
{ removeListener: [Function: updateExceptionCapture],
newListener: [Function: updateExceptionCapture],
error: [Function: debugDomainError] },
_eventsCount: 3,
_maxListeners: undefined,
members: [] } }
aion-127.0.0.1:8545> (node:13250) UnhandledPromiseRejectionWarning: Error: Returned error: Method not found
at Object.ErrorResponse (/home/sergiu/repos/aion_web3/packages/web3-core-helpers/src/errors.js:29:16)
at /home/sergiu/repos/aion_web3/packages/web3-core-requestmanager/src/index.js:140:36
at XMLHttpRequest.request.onreadystatechange (/home/sergiu/repos/aion_web3/packages/web3-providers-http/src/index.js:91:13)
at XMLHttpRequestEventTarget.dispatchEvent (/home/sergiu/repos/aion_web3/packages/web3-providers-http/node_modules/xhr2-cookies/dist/xml-http-request-event-target.js:34:22)
at XMLHttpRequest._setReadyState (/home/sergiu/repos/aion_web3/packages/web3-providers-http/node_modules/xhr2-cookies/dist/xml-http-request.js:208:14)
at XMLHttpRequest._onHttpResponseEnd (/home/sergiu/repos/aion_web3/packages/web3-providers-http/node_modules/xhr2-cookies/dist/xml-http-request.js:318:14)
at IncomingMessage. (/home/sergiu/repos/aion_web3/packages/web3-providers-http/node_modules/xhr2-cookies/dist/xml-http-request.js:289:61)
at IncomingMessage.emit (events.js:187:15)
at IncomingMessage.EventEmitter.emit (domain.js:460:23)
at endReadableNT (_stream_readable.js:1085:12)
```
Log from kernel:
```
18-09-12 12:18:35.237 DEBUG API [XNIO-1 task-83]: rpc-server - invalid method: eth_signTransaction [1]
```
Setup your profile
Tell us a little about you:
Skills
No results found for [[search]] .
Type to search skills..
Bio Required
[[totalcharacter]] / 240
Are you currently looking for work?
[[ option.string ]]
Next
Setup your profile
Our tools are based on the principles of earn (💰), learn (📖), and meet (💬).
Select the ones you are interested in. You can change it later in your settings.
I'm also an organization manager looking for a great community.
Back
Next
Save
Enable your organization profile
Gitcoin products can help grow community around your brand. Create your tribe, events, and incentivize your community with bounties. Announce new and upcoming events using townsquare. Find top-quality hackers and fund them to work with you on a grant.
These are the organizations you own. If you don't see your organization here please be sure that information is public on your GitHub profile. Gitcoin will sync this information for you.
Select the products you are interested in:
Out of the box you will receive Tribes Lite for your organization. Please provide us with a contact email:
Email
Back
Save
